Skip to content

Fix prometheus query for batch metrics #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2021
Merged

Fix prometheus query for batch metrics #1913

merged 4 commits into from
Mar 1, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Feb 26, 2021 •
edited
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@vishalbollu vishalbollu requested a review from miguelvr February 26, 2021 21:38
miguelvr
miguelvr approved these changes Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@miguelvr miguelvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelvr
Copy link
Collaborator

miguelvr commented Mar 1, 2021

@vishalbollu I just remember, that it might be relevant to update the metrics in the grafana dashboards

@vishalbollu vishalbollu merged commit 246caf5 into master Mar 1, 2021
@vishalbollu vishalbollu deleted the fix-prom-query-window-for-batch branch March 1, 2021 16:13
@vishalbollu vishalbollu added this to the v0.30 milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.30
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @miguelvr