Skip to content

Create .cortex dir if not present in Python Client #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Feb 25, 2021

If the ~/.cortex dir doesn't exist beforehand and a cluster-up/down is initiated using the python client installation (still using the binary), that will result in a FileNotFound error:

# example error from https://app.circleci.com/pipelines/github/cortexlabs/cortex/8642/workflows/e8042290-c5f1-4c8a-a278-aac2029056ec/jobs/11332
FileNotFoundError: [Errno 2] No such file or directory: '/home/circleci/.cortex/client-id.txt'

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Feb 25, 2021
@RobertLucian RobertLucian merged commit d64eae2 into master Feb 25, 2021
@RobertLucian RobertLucian deleted the fix/cortex-dir-not-existing branch February 25, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants