Skip to content

Improve S6 error code/signal handling #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 25, 2021
Merged

Improve S6 error code/signal handling #1825

merged 8 commits into from
Jan 25, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jan 22, 2021 •
edited
Loading

Fixes #1703.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian requested a review from deliahu January 22, 2021 23:42
deliahu
deliahu reviewed Jan 23, 2021
View reviewed changes
@RobertLucian RobertLucian merged commit 6467263 into master Jan 25, 2021
@RobertLucian RobertLucian deleted the fix/s6-problems branch January 25, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate if the use of "exec"s is mandated for the internal core services of the API
2 participants
@RobertLucian @deliahu