Skip to content

Reworking logs #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 14, 2021
Merged

Reworking logs #1778

merged 16 commits into from
Jan 14, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jan 12, 2021

closes #1732

  • reduce AWS specific logging implementation in favour generic structured logging tagged with cortex specific labels
  • update cortex application code to use json structured logging
  • use fluent-bit to massage and stream logs to a log aggregation tool, (Cloudwatch for AWS and Stackdriver for GCP)
  • update cortex logs CLI command to stream logs from a single running worker/replica as necessitated by the removal of AWS specific logging implementation

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

@vishalbollu vishalbollu requested a review from deliahu January 12, 2021 15:11
@vishalbollu vishalbollu requested a review from miguelvr January 14, 2021 02:43
Copy link
Collaborator

@miguelvr miguelvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nit's and some questions regarding logging, but overall LGTM

@vishalbollu vishalbollu merged commit 0dab2d7 into master Jan 14, 2021
@vishalbollu vishalbollu deleted the reworking-logs branch January 14, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow cortex logs to be forwarded to any logging service
3 participants