Skip to content

Add additional config path error wrapping and index to embeds #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Feb 18, 2019


Checklist:

  • Run automated tests (./build/test.sh)
  • Test end to end manually (e.g. rebuild registry/operator and run cx refresh in an example folder)
  • Add license header to each new file
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@deliahu deliahu requested a review from 1vn February 18, 2019 19:00
Copy link
Contributor

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Copy link
Contributor

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deliahu deliahu merged commit 0f7b5ee into master Feb 21, 2019
@deliahu deliahu deleted the config-paths branch February 21, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants