Skip to content

Show config path in config errors #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2019
Merged

Show config path in config errors #14

merged 4 commits into from
Feb 15, 2019

Conversation

1vn
Copy link
Contributor

@1vn 1vn commented Feb 14, 2019 •
edited
Loading

Checklist:

  • Add license header to each new file
  • Test end to end manually (e.g. rebuild registry/operator and run cx refresh in an example folder)
  • Run automated tests (./build/test.sh)
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick bugfixes into release branches
  • Delete the branch once it's merged

@1vn 1vn requested a review from deliahu February 14, 2019 22:26
deliahu
deliahu requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this!

deliahu
deliahu approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1vn 1vn merged commit 6a1fb24 into master Feb 15, 2019
@1vn 1vn deleted the file-errors branch February 15, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1vn @deliahu