Skip to content

Conversation

@jkbhagatio
Copy link
Member

No description provided.

@k1o0
Copy link
Contributor

k1o0 commented Oct 26, 2018

This is very hard to review :/ Did you change the order of the methods or did do something weird? It seems to think ever line was changed

@jkbhagatio
Copy link
Member Author

ah, did smart-indent on the file = D

@k1o0
Copy link
Contributor

k1o0 commented Oct 26, 2018

That makes sense. I change my smart indent to be 2 spaces instead of four. Four seems like too much to me. It bugs me about Python too...

@jkbhagatio
Copy link
Member Author

haha I was wondering when we'd get to the difference in stylistic preferences...

@k1o0
Copy link
Contributor

k1o0 commented Oct 26, 2018

I also prefer spaces around equals signs because it improves readability, and try to use as informative variable names as possible, even if they're quite long. Particularly if it doesn't cause a line to run on there's no disadvantage to having long variable names. When Pip first joined the lab all of his variables were four letters long and no one could read his code.

Copy link
Contributor

@k1o0 k1o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a line to print training prefs to the log, i.e. 'LEW010 marked for training on Saturday, Sunday and Tuesday'. Also try to stick as close as possible to the current style of the class/function, which was mostly inherited from Chris (except for the two space indent).

@jkbhagatio
Copy link
Member Author

hmm, yeah I sometimes don't do the whitespace around expression bindings because some languages don't read it, and I prefer shorter variable names, though I almost always explain all variable names in a comment

@jkbhagatio
Copy link
Member Author

updated as per your request

@k1o0 k1o0 merged commit 64677be into cortex-lab:dev Oct 26, 2018
k1o0 added a commit that referenced this pull request Jan 3, 2021
added future training flag to AlyxPanel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants