Skip to content

Strrep -> erase #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Strrep -> erase #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion +eui/ConditionPanel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ function onEdit(obj, src, eventData)
% See also FILLCONDITIONTABLE, EUI.PARAMEDITOR/UPDATE
row = eventData.Indices(1);
col = eventData.Indices(2);
assert(all(cellfun(@strcmpi, strrep(obj.ConditionTable.ColumnName, ' ', ''), ...
assert(all(cellfun(@strcmpi, erase(obj.ConditionTable.ColumnName, ' '), ...
obj.ParamEditor.Parameters.TrialSpecificNames)), 'Unexpected condition names')
paramName = obj.ParamEditor.Parameters.TrialSpecificNames{col};
newValue = obj.ParamEditor.update(paramName, eventData.NewData, row);
Expand Down
2 changes: 1 addition & 1 deletion addRigboxPaths.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function addRigboxPaths(varargin)
% computer only)
isInstalled = strcmp('GUI Layout Toolbox', {toolboxes.Name});
if ~any(isInstalled) ||...
str2double(strrep(toolboxes(isInstalled).Version,'.', '')) < 230
str2double(erase(toolboxes(isInstalled).Version,'.')) < 230
warning('Rigbox:setup:toolboxRequired',...
['MC requires GUI Layout Toolbox v2.3 or higher to be installed. '...
'Click <a href="matlab:web(''%s'',''-browser'')">here</a> to install.'],...
Expand Down
4 changes: 2 additions & 2 deletions tests/ParamEditor_test.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ function test_paramEdits(testCase)
testCase.verifyEqual(gLabels(idx).ForegroundColor, [1 0 0], ...
'Unexpected label colour')
% Verify change in underlying param struct
par = strcmpi(PE.Parameters.GlobalNames, strrep(gLabels(idx).String, ' ', ''));
par = strcmpi(PE.Parameters.GlobalNames, erase(gLabels(idx).String, ' '));
testCase.verifyEqual(PE.Parameters.Struct.(PE.Parameters.GlobalNames{par}), 666, ...
'UI edit failed to update parameters struct')
% Verify Changed event triggered
Expand All @@ -476,7 +476,7 @@ function test_paramEdits(testCase)
testCase.verifyEqual(gLabels(idx).ForegroundColor, [1 0 0], ...
'Unexpected label colour')
% Verify change in underlying param struct
par = strcmpi(PE.Parameters.GlobalNames, strrep(gLabels(idx).String, ' ', ''));
par = strcmpi(PE.Parameters.GlobalNames, erase(gLabels(idx).String, ' '));
testCase.verifyEqual(...
PE.Parameters.Struct.(PE.Parameters.GlobalNames{par}), gInputs(idx).Value==true, ...
'UI checkbox failed to update parameters struct')
Expand Down
2 changes: 1 addition & 1 deletion tests/checkCoverage.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
narginchk(1,2)
if nargin == 1
% Try to divine test function location
funLoc = fileparts(which(strrep(testFile,'_test','')));
funLoc = fileparts(which(erase(testFile,'_test')));
end
import matlab.unittest.TestRunner
import matlab.unittest.plugins.CodeCoveragePlugin
Expand Down
2 changes: 1 addition & 1 deletion tests/optimizations/ParamEditor_perfTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ function test_paramEdits(testCase)
'Unexpected label colour')
% Verify change in underlying param struct
par = strcmpi(PE.Parameters.GlobalNames,...
strrep(gLabels(idx).String, ' ', ''));
erase(gLabels(idx).String, ' '));
testCase.verifyEqual(PE.Parameters.Struct.(PE.Parameters.GlobalNames{par}), 666, ...
'UI edit failed to update parameters struct')

Expand Down