Exp server test

[k1o0]

• Full test coverage for expServer
• Added a test for structAssign
• Bug fix for updating alyx instance on quit
• More documentation
• Solutions for issues expServer test class #126 Task bar visible after gamma calibration #4 Print text to screen during calibrations #128 Listener prop in WSJCommunicator appears to be unused #139 Remove alyx/alyx-matlab warnings if Alyx is inactivated #202

[todo]

Make into shared fixture

Rigbox/tests/expServer_test.m

Lines 26 to 31 in 170a9dd

	% TODO Make into shared fixture
	assert(endsWith(which('dat.paths'),...
	fullfile('tests', 'fixtures', '+dat', 'paths.m')));
	% Check temp mainRepo folder is empty. An extra safe measure as we

---

This comment was generated by todo based on a TODO comment in 170a9dd in #203. cc @cortex-lab.

[todo]

Make into sequence

Rigbox/tests/fixtures/util/KbQueueCheck.m

Lines 44 to 49 in 170a9dd

	% FIXME Make into sequence
	KbQueue = containers.Map('KeyType', 'int32', 'ValueType', 'any');
	end
	if nargin < 2
	% Check the INTEST flag to ensure that calling mock was intended

---

This comment was generated by todo based on a FIXME comment in 170a9dd in #203. cc @cortex-lab.

[todo]

Call this from calibrate_test

Rigbox/tests/fixtures/util/mockRig.m

Lines 20 to 25 in 170a9dd

	% TODO Call this from calibrate_test
	% TODO Make into Fixture
	%
	% See also HW.DEVICES
	%
	% 2019-09-30 MW created

---

This comment was generated by todo based on a TODO comment in 170a9dd in #203. cc @cortex-lab.

[todo]

Make into Fixture

Rigbox/tests/fixtures/util/mockRig.m

Lines 21 to 26 in 170a9dd

	% TODO Make into Fixture
	%
	% See also HW.DEVICES
	%
	% 2019-09-30 MW created

---

This comment was generated by todo based on a TODO comment in 170a9dd in #203. cc @cortex-lab.

[jkbhagatio]

how would you feel about something like this?

      function c = calibration(obj, dev, lightIn, varargin)
      %  Creates a file that specifies gamma calibration for a screen.
      %  This function requires a user to hold a photodiode, connected to a NI-DAQ, against a screen in order
      %  to perform gamma calibration, and save the calibration settings to a file.
      %
      %  Inputs:
      %    dev (int) : NI DAQ device ID to which the photodiode is
      %      connected
      %    lightIn (char) : analogue input channel name to which the
      %      photodiode is connected
      % 
      %  Optional Inputs:
      %    clockIn (char) : analogue input channel name for clocking pulse
      %    clockOut (char) : digital output channel name for clocking pulse
      %    makePlot (bool) : flag for making photodiode signal plot
      %
      %  Outputs:
      %    c (struct) : calibration struct containing refresh rate and
      %      gamma tables
      %
      %  Examples:
      %
      % See also: `calibrationStruct`

I think having varargin and those optional inputs is clarifying here, and then an args struct could be used to specify default input args in the function body, which I like better than the if nargin < n

[k1o0]

fine

[jkbhagatio]

can you add comments for all the following variable declarations that serve as calibration parameters?

[k1o0]

The log should make these clear enough, otherwise it should be changed. What would you propose it say?

[jkbhagatio]

something like 'port to connect photodiode', 'first port to connect hook-up wire for chrono' 'second port to connect hook-up wire for chrono', 'synonomous port for clockOut'

[jkbhagatio]

Where is this class used? Is it used in anything not in a test?

[jkbhagatio]

following up on this

[k1o0]

This is used in a test on another branch that is not yet finished.