Fix gamma calibration #164
Conversation
|
Great! I will do this merge in the command line, because I will also add an accompanying test for the changes. By the way, we added a CONTRIBUTING file now, as we're trying to take a more thorough approach to adding/editing code, especially (hopefully?) with more contributors in the future. Generally, the workflow for adding code will be to create a pull-request to 'dev', and make sure the code is accompanied with an appropriate test, if a test does not already exist for the file. Since we're very early on in the stages of adding tests, it's ok for now if you don't want to create a test function each time you add/edit a few lines of code (that will be our responsibility). |
|
ok, makes sense, I will figure out the test functions in the future. Btw small note, but looks like there is no content at the readthedocs page?? I just followed the link from the main readme. |
|
check back in a couple weeks : ) |
|
@jaib1 It would be nice to add a fix for issue #128 too. |
|
also worth looking into #4 - will do this today |
+srv/expServer.m
Outdated
| clockOut = 'port1/line0 (PFI4)'; | ||
| log(['Please connect photodiode to %s, clockIn to %s and clockOut to %s.\r'... | ||
| 'Press any key to contiue\n'],lightIn,clockIn,clockOut); | ||
| lightIn = 'ai1'; % defaults from hw.psy.Window |
There was a problem hiding this comment.
@nsteinme why did you switch the lightin and clockIn channels here? I just ran gamma calibration with the old channels and it worked fine (though it also works with your suggested channels)
There was a problem hiding this comment.
As this doesn't affect things I'm happy to go ahead with this merge. I will fix the typo on line 362 first though...
* use the correct channels for gamma cal as specified * label output plots correctly
* use the correct channels for gamma cal as specified * label output plots correctly
3 participants
We had some trouble with gamma calibration and these commits fix a bug and label plots more usefully - we'd have succeeded much faster with these changes.