Replace devd.io with localhost for local routing#129
Replace devd.io with localhost for local routing#129chebread wants to merge 1 commit intocortesi:masterfrom
Conversation
This commit changes the default virtual hosting domain from devd.io to localhost (and *.localhost). Resolves cortesi#128
|
Does |
| "testing" | ||
|
|
||
| "github.com/GeertJohan/go.rice" | ||
| rice "github.com/GeertJohan/go.rice" |
There was a problem hiding this comment.
go fmt wants it this way? i guess this can be cleaned up eventually if wader@283f73d can be merged
There was a problem hiding this comment.
I am using Go version 1.26.0 darwin/arm64. On March 21 at 20:00 KST, I cloned the devd repository from GitHub and ran (tested) gofmt in the route_test.go file. I found that the rice code was added by gofmt, not by me!
|
Also would be great to fix CI, i have a PR to start moving to github actions @cortesi Ok for you if we start merge stuff? i think we might need help to enable github action if i remember correctly |
I also encountered the same error as you when I ran |
I agree with that as well. |
Fixes #128
Problem:
The default domain
devd.iono longer resolves to a local address (127.0.0.1).Solution:
Replaced
devd.iowithlocalhost(and*.localhost) as the default domain for virtual hosting. According to RFC 6761,*.localhostis universally recognized and guaranteed to resolve to the loopback address locally in all operating systems and modern browsers, removing the dependency on external DNS.Changes:
template.DNSNamesfromdevd.iotolocalhostincertgen.goroutespec.goserver.goroute_test.goandserver_test.goREADME.mdto reflect the newlocalhostbehavior