Skip to content

fix: publish GitHub - #2760

Merged
wayfarer3130 merged 2 commits into
mainfrom
fix/publish-github
Jun 11, 2026
Merged

wayfarer3130 merged 2 commits into
mainfrom
fix/publish-github

Conversation

@wayfarer3130

@wayfarer3130 wayfarer3130 commented Jun 11, 2026 •

Copy link
Copy Markdown
Collaborator

Switched to direct API usage for gh publish because gh isn't installed in the image
Also update to pnpm 11.5.2.

OHIF_REF: feat/ohifpnpm2

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Summary by CodeRabbit

  • Chores
    • Updated pnpm package manager to version 11.5.2 across all build workflows and project configuration.
    • Enhanced GitHub release creation process with improved implementation.

@wayfarer3130
wayfarer3130 requested a review from sedghi June 11, 2026 14:01
@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d79afb99-a9c0-40f5-83ca-702c70a3778a

📥 Commits

Reviewing files that changed from the base of the PR and between b1f35af and 55e8d87.

📒 Files selected for processing (10)
  • .github/workflows/build-docs.yml
  • .github/workflows/docusaurus-build.yml
  • .github/workflows/format-check.yml
  • .github/workflows/ohif-downstream.yml
  • .github/workflows/playwright.yml
  • .github/workflows/test.yml
  • .github/workflows/validate-codemod-registry.yml
  • README.md
  • package.json
  • publish-version.mjs

📝 Walkthrough

Walkthrough

This PR updates pnpm from version 11.4.0 to 11.5.2 across all CI workflows and configuration files, and refactors the GitHub release creation logic in publish-version.mjs to use the GitHub REST API directly instead of the gh CLI tool.

Changes

pnpm Version Pinning

Layer / File(s) Summary
pnpm 11.4.0 → 11.5.2 across all CI workflows and configuration
.github/workflows/build-docs.yml, .github/workflows/docusaurus-build.yml, .github/workflows/format-check.yml, .github/workflows/ohif-downstream.yml, .github/workflows/playwright.yml, .github/workflows/test.yml, .github/workflows/validate-codemod-registry.yml, package.json, README.md
All GitHub Actions workflows are updated to pin pnpm 11.5.2. The root packageManager field in package.json and the Local Setup documentation in README.md are updated to match.

GitHub Release Creation via REST API

Layer / File(s) Summary
GitHub release creation via REST API
publish-version.mjs
createGithubRelease parses the GitHub repository slug from git remote.origin.url, then creates releases by POSTing directly to the GitHub REST API endpoint with bearer token authentication. Prerelease detection and all error handling remain best-effort with non-fatal logging.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • sedghi

Poem

🐰 A version bump hops through the workflows with glee,
From 11.4.0 to 11.5.2, consistency achieved!
And the release script learns a REST API dance,
No more CLI calls—just fetch and a glance.
Hop, hop, release! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete; most required template sections (Context, Changes & Results, Testing, Checklist items) remain unfilled placeholders, and no concrete details about the API change implementation or testing approach are provided. Fill in the Context section with issue links or reason for the API switch, detail the Changes & Results with before/after comparison, add Testing steps, and complete the Checklist items.
Title check ❓ Inconclusive The title 'fix: publish GitHub' is vague and lacks specificity about the actual changes; it doesn't clearly convey that the fix involves switching from gh CLI to direct API usage. Consider using a more descriptive title like 'fix: use GitHub API for publish instead of gh CLI' to better reflect the primary change.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/publish-github

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wayfarer3130
wayfarer3130 merged commit a3702d0 into main Jun 11, 2026
15 checks passed
@wayfarer3130
wayfarer3130 deleted the fix/publish-github branch June 11, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants