Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dicomImageLoader): Switch JPEG lossless decoder and add more tests #1568

Merged
merged 11 commits into from
Nov 11, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Nov 8, 2024

This pull request includes significant updates to the dicomImageLoader package, primarily focusing on switching the JPEG lossless decoder library and adding new screenshot paths for various DICOM image formats. Additionally, there is a minor update to a documentation file.

Decoder Library Update:

  • Updated the package.json to include the jpeg-lossless-decoder-js library.
  • Modified the initialize and decodeJPEGLossless functions in decodeJPEGLossless.ts to use the new jpeg-lossless-decoder-js library instead of the previous jpegLossless codec. [1] [2]

Screenshot Paths:

  • Added multiple new screenshot paths for different DICOM image formats in screenShotPaths.ts.

Documentation Update:

  • Updated the Vimeo video link in the playwright-tests.md documentation file.

Copy link

stackblitz bot commented Nov 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit 3125042
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/673234e6c902880008aeb522

@sedghi sedghi changed the title fix jpeg lossless maybe feat(dicomImageLoader): Switch JPEG lossless decoder and add more tests Nov 8, 2024
@sedghi sedghi merged commit b6a29a2 into main Nov 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant