-
Notifications
You must be signed in to change notification settings - Fork 4
Rename source type parameters to H #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice! That is a good idea. From my side, you can rename all of them including |
|
This should be good to go. |
|
One should never be too sure. Should be good to go for real this time. |
cornerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you :)
This PR renames all type parameters that use the
Sourcetypeclass toH[_] : Source.All the others already are consistently named so why
Sourcetoo...We now have:
F[_] : Sync(orEffectand so on)G[_] : SinkH[_] : SourceThis is in preparation for adding
F[_] : Synceffect types toonNext,onErrorandsubscribeto avoid ambiguities with the other parameters.There are some usages of
SinkandSourcenamedSI[_] : SinkandSO[_] : Sourcerespectively. Should these also be renamed accordingly? AlsoGA,GB,SAandSBare sometimes used. Should I rename the latter toHAandHB?