Skip to content

Conversation

@busti
Copy link
Contributor

@busti busti commented Sep 25, 2021

This PR renames all type parameters that use the Source typeclass to H[_] : Source.
All the others already are consistently named so why Source too...
We now have:

  • F[_] : Sync (or Effect and so on)
  • G[_] : Sink
  • H[_] : Source

This is in preparation for adding F[_] : Sync effect types to onNext, onError and subscribe to avoid ambiguities with the other parameters.

There are some usages of Sink and Source named SI[_] : Sink and SO[_] : Source respectively. Should these also be renamed accordingly? Also GA, GB, SA and SB are sometimes used. Should I rename the latter to HA and HB?

@cornerman
Copy link
Owner

cornerman commented Sep 26, 2021

Nice! That is a good idea.

From my side, you can rename all of them including SI, SO, GA and so on. Definitely makes it more consistent. Feel free to improve the naming as you see fit :)

@busti
Copy link
Contributor Author

busti commented Sep 29, 2021

This should be good to go.

@busti
Copy link
Contributor Author

busti commented Sep 29, 2021

One should never be too sure.
Caught that one just in time.

Should be good to go for real this time.

@busti busti changed the title [Wip] Rename source type parameters to H Rename source type parameters to H Sep 29, 2021
Copy link
Owner

@cornerman cornerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants