Skip to content

Make jaxtyping dep install requirement#60

Merged
Balandat merged 4 commits intocornellius-gp:mainfrom
Balandat:jaxtyping_dep
May 3, 2023
Merged

Make jaxtyping dep install requirement#60
Balandat merged 4 commits intocornellius-gp:mainfrom
Balandat:jaxtyping_dep

Conversation

@Balandat
Copy link
Collaborator

@Balandat Balandat commented May 3, 2023

Make jaxtyping and typeguard required dependencies

See #42 (comment)

Also removes the packaging dep, which is transitive through pytest: https://github.com/pytest-dev/pytest/blob/main/setup.cfg#L48

@Balandat
Copy link
Collaborator Author

Balandat commented May 3, 2023

Hmm @gpleiss looks like typeguard is a required dep of jaxtyping. We've had issues with running typeguard on internal infra, so this isn't great. Is there a way to make jaxtyping truly a test-time requirement only as we initially intended with #42?

@Balandat
Copy link
Collaborator Author

Balandat commented May 3, 2023

cc @mpolson64

@Balandat
Copy link
Collaborator Author

Balandat commented May 3, 2023

Merging this to resolve breakage of dev version install.

@Balandat Balandat merged commit 171432b into cornellius-gp:main May 3, 2023
@Balandat Balandat deleted the jaxtyping_dep branch May 3, 2023 15:37
@gpleiss gpleiss mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant