Format using ufmt, upgrade pre-commit config#56
Merged
gpleiss merged 1 commit intocornellius-gp:mainfrom Apr 14, 2023
Merged
Conversation
This PR introduces the us of ufmt (instead of black + isort) for auto-formatting and import sorting to avoid collisions between the two. It also upgrades some of the versions in the pre-commit config. As a result, quire a few files were reformatted.
Balandat
commented
Mar 30, 2023
|
|
||
| def _compute_getitem_size( | ||
| obj: Union[torch.Tensor, "LinearOperator"], indices: Tuple[Union[slice, torch.LongTensor, int], ...] # noqa F811 | ||
| obj: Union[torch.Tensor, "LinearOperator"], # noqa F821 |
Collaborator
Author
There was a problem hiding this comment.
I had to silence what I think is a spurious flake8 error here, this complained about LinearOperator not being known / imported ...
Member
|
I'm very much in favor of this. I'm going to hopefully get #42 in early next week and then we can merge this. |
Collaborator
Author
The reason for this is avoiding a not-so-nice rebase I take it? |
gpleiss
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the us of ufmt (instead of black + isort) for auto-formatting and import sorting to avoid collisions between the two. It also upgrades some of the versions (flake8 -> 5.0.4, flake8-print -> 5.0.0, pre-commit-hooks -> 4.4.0). As a result, quire a few files were reformatted.