Remove @cached decorator for TriangularLinearOperator.to_dense#51
Merged
gpleiss merged 2 commits intocornellius-gp:mainfrom Feb 27, 2023
Merged
Remove @cached decorator for TriangularLinearOperator.to_dense#51gpleiss merged 2 commits intocornellius-gp:mainfrom
gpleiss merged 2 commits intocornellius-gp:mainfrom
Conversation
This seems unnecessary and also causes issues with pickling: cornellius-gp/gpytorch#2264 (comment)
Collaborator
|
My gut instinct is that this is right, since I've seen the same dense tensor getting cached to multiple places, including via this function. If this causes any performance degradation, hopefully the BoTorch tutorials runs and the tracking I'm adding to them would pick that up (meta-pytorch/botorch#1695). |
gpleiss
approved these changes
Feb 27, 2023
Balandat
added a commit
to Balandat/linear_operator
that referenced
this pull request
May 3, 2023
Repeat of cornellius-gp#51, as this snuck in with cornellius-gp#42.
gpleiss
pushed a commit
that referenced
this pull request
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems unnecessary and also causes issues with pickling: cornellius-gp/gpytorch#2264 (comment)