Convert base_linear_op to a dense linear operator in BlockDiagLinearOperator#119
Merged
Balandat merged 2 commits intocornellius-gp:mainfrom Dec 15, 2025
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #118 by ensuring that tensor inputs to BlockDiagLinearOperator are properly converted to DenseLinearOperator instances before being processed. This is necessary because the parent class BlockLinearOperator calls LinearOperator-specific methods like _permute_batch() on base_linear_op when block_dim != -3, which would fail for raw tensors.
Key Changes:
- Added tensor-to-LinearOperator conversion in
BlockDiagLinearOperator.__init__() - Added test class
TestBlockDiagLinearOperatorFromTensorto validate tensor initialization - Minor style improvement removing unnecessary parentheses in tuple unpacking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
linear_operator/operators/block_diag_linear_operator.py |
Added import of DenseLinearOperator and conversion logic in constructor to wrap tensor inputs before passing to parent class |
test/operators/test_block_diag_linear_operator.py |
Added _initialize_from_tensor flag and new test class to verify tensor initialization works correctly, plus minor style fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would fix #118.
In general, many operations in
BlockDiagLinearOperatorassume thatbase_linear_opis a linear operator. Thus, it's better to convert it into a linear operator in the constructor.Added test cases to cover the change.