increase the default max Cholesky size to 50000#117
Open
kayween wants to merge 1 commit intocornellius-gp:mainfrom
Open
increase the default max Cholesky size to 50000#117kayween wants to merge 1 commit intocornellius-gp:mainfrom
kayween wants to merge 1 commit intocornellius-gp:mainfrom
Conversation
Member
|
50000 seems like too much for older GPUs. Is there some way we could try 50000, and then adjust if we get OOM errors? |
Collaborator
Author
|
Sounds reasonable. I will put together a prototype and update this PR. |
Collaborator
|
Also, lots of people run stuff on CPU and so we definitely want to be careful about cranking the size up too much by default... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as titled