Remove version pins for mpmath and typeguard#112
Merged
gpleiss merged 1 commit intocornellius-gp:mainfrom Oct 1, 2025
Merged
Conversation
These are old pins that are unnecssary at this point: - `typeguard` is not a dependency of `jaxtyping` since https://github.com/patrick-kidger/jaxtyping/releases/tag/v0.2.35 - the `mpmath` version incompatibility has been resolved in newer sympy versions: sympy/sympy#26273 (comment)
gpleiss
approved these changes
Oct 1, 2025
Member
|
LGTM, as long as the tests pass :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are old pins that are unnecssary at this point:
typeguardis not a dependency ofjaxtypingsince https://github.com/patrick-kidger/jaxtyping/releases/tag/v0.2.35mpmathversion incompatibility has been resolved in newer sympy versions: AttributeError: module 'mpmath' has no attribute 'rational' sympy/sympy#26273 (comment)