Skip to content

Conversation

Oh-Afterglow
Copy link
Contributor

Description

This pull request provides a FEATHER example of performing a 2D convolution operation and switching the layout from channel-last to row major at the same time, which is illustrated in Fig.11 of the paper.

The FEATHER kernel in this example is mostly the same as the GEMM example, except for the parameters determining the sizes of input buffers.

The configurable parameters of this example includes NEST parameters AW and AH, and the 7 dimensions (NCHWMRS) of convolution operation. The source code contains more detailed explanation of the parameters.

Checklist

Please make sure to review and check all of these items:

  • PR's title starts with a category (e.g. [Bugfix], [IR], [Builder], etc)
  • All changes have test coverage (It would be good to provide ~2 different test cases to test the robustness of your code)
  • Pass the formatting check locally
  • Code is well-documented

Comment on lines +8 to +9
# The FEATHER implementation in this file is generally same
# as the one in gemm.py except for parameters that describe inputs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we should put gemm and conv in the same file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think so, although the GEMM example needs some modifications before merging, since its number of PE local registers (arbitrarily configurable) is not exactly complied with the original FEATHER design (=AH). The FEATHER implementation in this convolution example is a more correct one.

@Oh-Afterglow Oh-Afterglow marked this pull request as draft October 9, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants