Support Anthropology Major #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
[diff-counting] Significant lines: 116. |
|
Visit the preview URL for this PR (updated for commit 446a212): https://cornelldti-courseplan-dev--pr869-add-anthropology-maj-2zy73apu.web.app (expires Wed, 06 Dec 2023 04:10:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
elizabeth-tang
requested changes
Nov 5, 2023
elizabeth-tang
approved these changes
Nov 13, 2023
|
Should I squash and merge? |
andxu282
pushed a commit
that referenced
this pull request
Feb 29, 2024
* feat: add anthropology major * fix: improve grammar for anthropology req * fix: update requirements file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rite of passage — added support for A&S's anthropology major. This involved updating
index.tsand addinganthr.tsin thesrc/datafolder. Also updated the requirements JSON file as required.You can find major requirements for this degree over here.
Test Plan
Updated the huge JSON file and requirements generator. All tests passed. Behold the new Anthropology major visually as well:
I also tried to add various classes on localhost but it didn't seem to persist / was a bit buggy. However, the same problem was happening for my existing data (e.g. adding new CS major classes) so I'm not sure if it's possible to test this manually like that.
Notes
The anthropology major is easier to obtain than I thought.
Blockers
N/A
Breaking Changes
N/A