Implement 'serve:prod' Script #843
Conversation
Implements a 'serve:prod' script, allowing devs to build and test CoursePlan locally for production.
|
[diff-counting] Significant lines: 0. |
|
Visit the preview URL for this PR (updated for commit bf948dc): https://cornelldti-courseplan-dev--pr843-zak-serve-prod-re7473bi.web.app (expires Tue, 26 Sep 2023 23:12:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
| @@ -4,6 +4,7 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "serve": "vite", | |||
| "serve:prod": "vite --mode production", | |||
There was a problem hiding this comment.
Is it possible that devs may accidentally modify the production data by spinning up a local build that uses production data?
I don't suspect this happening since only the owner of the data can modify it (i.e the email check in the read/write rules in firestore), but I wanted to ask to make sure its been considered!
There was a problem hiding this comment.
Yeah it definitely is possible that someone could nuke their own prod data like this, but they won't be able to modify anyone else's.
Summary
Implements a 'serve:prod' script, allowing devs to build and test CoursePlan locally for production.
Test Plan
Run
npm run serve:prodand check that you can view your production data on CoursePlan.