Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basic User Properties to Analytics #803

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

zachary-kent
Copy link
Collaborator

@zachary-kent zachary-kent commented Mar 22, 2023

Summary

Modifies our analytics infrastructure to log the user's graduation year and majors with every event; a temporary solution until the migration in #804 can be safely merged.

Test Plan

If you have access to google analytics, navigate to the real time event report and look at the "User by user property card." Then, on my branch, perform some action that will log an analytics event, like adding a course. This event, with your corresponding graduation year and major, should be reflected on the analytics dashboard:

Screenshot 2023-03-22 at 5 17 31 PM

@zachary-kent zachary-kent requested a review from a team as a code owner March 22, 2023 21:18
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 78.

@zachary-kent zachary-kent requested a review from KaylinChan March 22, 2023 21:19
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 1b420bc):

https://cornelldti-courseplan-dev--pr803-user-properties-ah11y2my.web.app

(expires Fri, 21 Apr 2023 21:19:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

@noschiff
Copy link
Member

@zachary0kent how are you handling ≥ 1 major?

Copy link
Contributor

@KaylinChan KaylinChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested by adding/deleting a couple of courses as different majors on your branch, and it was reflected in the Realtime Analytics report in Users by User Property as well as Events. Everything looks good!!

@zachary-kent
Copy link
Collaborator Author

zachary-kent commented Mar 24, 2023

@zachary0kent how are you handling ≥ 1 major?

I log all of the user's majors as an array

@zachary-kent zachary-kent merged commit ccc4dcf into master Mar 25, 2023
@zachary-kent zachary-kent deleted the user-properties branch March 25, 2023 04:34
@noschiff noschiff mentioned this pull request Apr 26, 2023
22 tasks
This was referenced May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants