Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Earth and atmosphere Minor #779

Merged
merged 7 commits into from
Feb 22, 2023

Conversation

rohanmaheshwari430
Copy link
Contributor

Summary

In this PR, we add the requirements for the Earth And Atmospheric Sciences minor to the data/minors directory.

Details about the requirements to fulfill this minor can be found here: EAS Minor Requirements

Test Plan

ran npm run test -- -u to update the requirements snapshot

ran npm test to ensure that the addition of the minor and its requirements did not affect previous infrastructure.

@rohanmaheshwari430 rohanmaheshwari430 requested a review from a team as a code owner February 16, 2023 03:49
@CLAassistant
Copy link

CLAassistant commented Feb 16, 2023

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 16, 2023

[diff-counting] Significant lines: 69.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

Visit the preview URL for this PR (updated for commit 75090b4):

https://cornelldti-courseplan-dev--pr779-earth-and-atmosphere-9vr6c7r0.web.app

(expires Fri, 24 Mar 2023 00:15:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

@rohanmaheshwari430 rohanmaheshwari430 changed the title Added Earth and atmosphere MNinor Added Earth and atmosphere Minor Feb 16, 2023
Copy link
Collaborator

@zachary-kent zachary-kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh, I am not sure of the best way to handle this case. I think it's okay to merge until we have a better solution.

Copy link
Collaborator

@zachary-kent zachary-kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added the EAS major and poked at the requirements a bit.

@rohanmaheshwari430 rohanmaheshwari430 merged commit bf095d0 into master Feb 22, 2023
@rohanmaheshwari430 rohanmaheshwari430 deleted the earth-and-atmosphere-minor branch February 22, 2023 01:12
@noschiff noschiff mentioned this pull request Apr 26, 2023
22 tasks
This was referenced May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants