-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Earth and atmosphere Minor #779
Conversation
[diff-counting] Significant lines: 69. |
Visit the preview URL for this PR (updated for commit 75090b4): https://cornelldti-courseplan-dev--pr779-earth-and-atmosphere-9vr6c7r0.web.app (expires Fri, 24 Mar 2023 00:15:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh, I am not sure of the best way to handle this case. I think it's okay to merge until we have a better solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added the EAS major and poked at the requirements a bit.
Summary
In this PR, we add the requirements for the Earth And Atmospheric Sciences minor to the data/minors directory.
Details about the requirements to fulfill this minor can be found here: EAS Minor Requirements
Test Plan
ran
npm run test -- -u
to update the requirements snapshotran
npm test
to ensure that the addition of the minor and its requirements did not affect previous infrastructure.