[Easy] Fix Navigation Bug #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 0. |
|
Visit the preview URL for this PR (updated for commit c5f0503): https://cornelldti-courseplan-dev--pr757-fix-nav-bug-8gv8218l.web.app (expires Fri, 02 Dec 2022 03:55:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
noschiff
approved these changes
Nov 2, 2022
@zachary0kent the disrespect 🤔 |
Can you expand on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where closing the profile modal from the tools page brings you back to the plan page. Note this is still currently broken for the new gatekept profile page, but resolved in #712.
Test Plan
Open the profile while on tools and then close the profile. Ensure you're still on tools.