Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Fix linting for enums #752

Merged
merged 2 commits into from
Oct 28, 2022
Merged

[Easy] Fix linting for enums #752

merged 2 commits into from
Oct 28, 2022

Conversation

zachary-kent
Copy link
Collaborator

Summary

Modifies our .eslintrc file to lint enums correctly. The no-shadow rule currently fails on enum declarations for some reason; this fixes it.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 0.

@zachary-kent zachary-kent marked this pull request as ready for review October 28, 2022 17:35
@zachary-kent zachary-kent requested a review from a team as a code owner October 28, 2022 17:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

Visit the preview URL for this PR (updated for commit 99044e6):

https://cornelldti-courseplan-dev--pr752-lint-enums-gqv5n79v.web.app

(expires Sun, 27 Nov 2022 17:36:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

Copy link
Member

@noschiff noschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachary-kent zachary-kent merged commit 422d28f into master Oct 28, 2022
@zachary-kent zachary-kent deleted the lint-enums branch October 28, 2022 18:08
@noschiff noschiff mentioned this pull request Nov 2, 2022
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants