Skip to content

Conversation

willespencer
Copy link
Member

@willespencer willespencer commented Apr 20, 2022

Summary

This pull request adds a new warning to the transfer page of onboarding. The purpose of this warning is to notify users about AP/IB bugs before merging the next release (#680).

image

Test Plan

👀

Notes

As a follow-up to this PR, the gatekeep to hide AP/IB fulfillment will be removed.

@willespencer willespencer requested a review from einc April 20, 2022 20:41
@willespencer willespencer requested a review from a team as a code owner April 20, 2022 20:41
@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 20, 2022

[diff-counting] Significant lines: 24.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

Visit the preview URL for this PR (updated for commit cbca44c):

https://cornelldti-courseplan-dev--pr683-transfer-credit-warn-ghclm19b.web.app

(expires Tue, 24 May 2022 21:30:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@@ -52,6 +52,10 @@
>here</a
>.
</div>
<div class="onboarding-transferCreditDescription">
*Some transfer credits may incorrectly apply to requirements. We are working to fix these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a designer, but I'm not a big fan of the * before the warning (and before the warning above). The text is already small and gray, so I already recognize it as "extra information". Having two *s is a little intrusive and uneven IMO.

@jerrry1123
Copy link
Contributor

I'm also not a designer, but I feel like the message should at least be the first message and maybe bolded since it's a pretty important thing for students to know and definitely more important than the second message.

@noschiff noschiff added the front-end Front-end improvement or feature label Apr 24, 2022
Copy link
Member

@noschiff noschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This design is much better; thanks Will! LGTM!

Copy link
Contributor

@einc einc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for adding this so fast <3

@willespencer willespencer merged commit c04efa9 into master Apr 25, 2022
@willespencer willespencer deleted the transfer-credit-warning branch April 25, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Front-end improvement or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants