-
Notifications
You must be signed in to change notification settings - Fork 13
Add new warning to transfer page of onboarding #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[diff-counting] Significant lines: 24. |
Visit the preview URL for this PR (updated for commit cbca44c): https://cornelldti-courseplan-dev--pr683-transfer-credit-warn-ghclm19b.web.app (expires Tue, 24 May 2022 21:30:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
@@ -52,6 +52,10 @@ | |||
>here</a | |||
>. | |||
</div> | |||
<div class="onboarding-transferCreditDescription"> | |||
*Some transfer credits may incorrectly apply to requirements. We are working to fix these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a designer, but I'm not a big fan of the * before the warning (and before the warning above). The text is already small and gray, so I already recognize it as "extra information". Having two *
s is a little intrusive and uneven IMO.
I'm also not a designer, but I feel like the message should at least be the first message and maybe bolded since it's a pretty important thing for students to know and definitely more important than the second message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This design is much better; thanks Will! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thanks for adding this so fast <3
Summary
This pull request adds a new warning to the transfer page of onboarding. The purpose of this warning is to notify users about AP/IB bugs before merging the next release (#680).
Test Plan
👀
Notes
As a follow-up to this PR, the gatekeep to hide AP/IB fulfillment will be removed.