Remove tools feature flag (#746)

* Remove tools feature flag * remove unused import
cornell-dti · Nov 2, 2022 · ca4a8e9 · ca4a8e9
1 parent 0da5566
commit ca4a8e9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 36 deletions.
diff --git a/src/components/NavBar.vue b/src/components/NavBar.vue
@@ -13,24 +13,13 @@
         <div class="navbar-iconWrapper hairlineWrapper no-hover">
           <img class="navbar-icon hairline" src="@/assets/images/navbar/hairline.svg" />
         </div>
-
-        <div
-          v-if="showOpenPlan"
-          class="navbar-buttonWrapper desktop"
-          @click="openPlan"
-          data-cyId="openPlan"
-        >
+        <div class="navbar-buttonWrapper desktop" @click="openPlan" data-cyId="openPlan">
           <button class="navbar-iconWrapper plan-icon full-opacity-on-hover" />
           <div class="navbar-iconText">
             <span>Plan</span>
           </div>
         </div>
-        <div
-          v-if="toolsEnabled"
-          class="navbar-buttonWrapper desktop"
-          @click="openTools"
-          data-cyId="openTools"
-        >
+        <div class="navbar-buttonWrapper desktop" @click="openTools" data-cyId="openTools">
           <button class="navbar-iconWrapper tools-icon full-opacity-on-hover" />
           <div class="navbar-iconText">
             <span>Tools</span>
@@ -60,21 +49,11 @@
             {{ isDisplayingRequirementsMobile ? 'View Schedule' : 'View Requirements' }}
           </span>
         </button>
-        <button
-          v-if="showOpenPlan"
-          class="nav-mobile-button"
-          data-cyId="navbar-openPlan"
-          @click="openPlan"
-        >
+        <button class="nav-mobile-button" data-cyId="navbar-openPlan" @click="openPlan">
           <div class="navbar-iconWrapper plan-mobile-icon" />
           <span class="nav-mobile-button-text">Plan</span>
         </button>
-        <button
-          v-if="toolsEnabled"
-          class="nav-mobile-button"
-          data-cyId="navbar-openTools"
-          @click="openTools"
-        >
+        <button class="nav-mobile-button" data-cyId="navbar-openTools" @click="openTools">
           <div class="navbar-iconWrapper tools-mobile-icon" />
           <span class="nav-mobile-button-text">Tools</span>
         </button>
@@ -105,7 +84,6 @@ import { defineComponent } from 'vue';
 import { getAuth, signOut } from 'firebase/auth';
 import { GTagEvent } from '@/gtag';
 import { clickOutside } from '@/utilities';
-import featureFlagCheckers from '@/feature-flags';
 
 export default defineComponent({
   props: {
@@ -117,14 +95,6 @@ export default defineComponent({
       menuOpen: false,
     };
   },
-  computed: {
-    toolsEnabled(): boolean {
-      return featureFlagCheckers.isToolsEnabled();
-    },
-    showOpenPlan(): boolean {
-      return this.toolsEnabled || featureFlagCheckers.isProfileEnabled();
-    },
-  },
   methods: {
     logout() {
       GTagEvent(this.$gtag, 'logout');

diff --git a/src/feature-flags.ts b/src/feature-flags.ts
@@ -8,7 +8,6 @@ type FeatureFlagName =
   | 'RequirementConflicts'
   | 'RequirementDebugger'
   | 'ToggleRequirementsBarBtn'
-  | 'Tools'
   | 'Profile';
 /* | 'AddYourFeatureFlagNameHere' */
 const featureFlagCheckers: FeatureFlagCheckers = registerFeatureFlagChecker(
@@ -17,7 +16,6 @@ const featureFlagCheckers: FeatureFlagCheckers = registerFeatureFlagChecker(
   'RequirementConflicts',
   'RequirementDebugger',
   'ToggleRequirementsBarBtn',
-  'Tools',
   'Profile'
   /* 'AddYourFeatureFlagNameHere' */
 );