Move AS check to utilities to return in all locations

src/components/Requirements/RequirementHeader.vue

@@ -27,7 +27,7 @@
           }"
           class="college-title-top"
         >
-          {{ getCollegeFullName(collegeAcronym) }}
+          {{ getCollegeFullName(onboardingData.college) }}
         </p>
       </button>
     </div>
@@ -213,11 +213,6 @@ export default defineComponent({
     },
   },
   computed: {
-    // get college acronym, but special case for A&S to be switched from AS1/AS2 to just AS
-    collegeAcronym(): string {
-      const acronym = this.onboardingData.college ?? '';
-      return acronym.includes('AS') ? 'AS' : acronym;
-    },
     // number of fully fulfilled requirements, note pure self-checks are never fulfilled
     requirementFulfilled(): number {
       let fulfilled = 0;

src/utilities.ts

@@ -49,11 +49,13 @@ export function getCurrentYear(): number {
 export const yearRange = 6;
 
 export function getCollegeFullName(acronym: string | undefined): string {
-  // Return empty string if college is not in requirementJSON
-  if (acronym === 'AS') {
+  // return Arts and Sciences for AS, AS1, or AS2
+  if (acronym && acronym.startsWith('AS')) {
     return 'Arts and Sciences';
   }
   const college = acronym ? requirementJSON.college[acronym] : null;
+
+  // Return empty string if college is not in requirementJSON
   return college ? college.name : '';
 }