fixed order by (#903)

* fixed order by

* delete console

src/components/Requirements/MultiplePlansDropdown.vue

@@ -87,6 +87,7 @@ export default defineComponent({
           'setCurrentPlan',
           store.state.plans.find(p => p.name === plan)
         );
+        store.commit('setOrderByNewest', store.state.orderByNewest);
         this.shown = !this.shown;
       }
     },

src/components/Requirements/RequirementSideBar.vue

@@ -393,6 +393,7 @@ export default defineComponent({
         'setCurrentPlan',
         store.state.plans.find(plan => plan.name === name)
       );
+      store.commit('setOrderByNewest', store.state.orderByNewest);
       this.confirmationText = `${oldname} has been renamed to ${name}!`;
       this.isConfirmationOpen = true;
       setTimeout(() => {

src/global-firestore-data/user-semesters.ts

@@ -28,6 +28,7 @@ export const editPlans = async (
   await updateDoc(doc(semestersCollection, store.state.currentFirebaseUser.email), {
     plans,
   });
+  store.commit('setOrderByNewest', store.state.orderByNewest);
 };
 /**
  * Sets whether semesters are ordered by newest/oldest

src/store.ts

@@ -177,7 +177,9 @@ const store: TypedVuexStore = new TypedVuexStore({
         name: state.currentPlan.name,
         semesters: sortedSemesters(semesters, state.orderByNewest),
       };
-      const editedPlans = state.plans.map(plan => (plan === state.currentPlan ? editedPlan : plan));
+      const editedPlans = state.plans.map(plan =>
+        plan.name === state.currentPlan.name ? editedPlan : plan
+      );
       state.plans = editedPlans;
       state.currentPlan = editedPlan;
     },