Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Modal redesign for Available drivers #519

Closed
wants to merge 2 commits into from

Conversation

Atikpui007
Copy link
Collaborator

Summary

This pull request is the first step towards implementing the design changes suggested by Lazim for the available drivers in the following figma.

  • Added Scrollability and Organization of drivers
  • Form validation and resetting for selected drivers
  • Display extra driver information including picture, time
  • Driver sorting by start time , end time , name
  • Quick popup tooltip to show driver information on hover

Test Plan

Previous look
Screenshot 2024-05-05 at 10 29 53 PM

WIP Current look no selected
Screenshot 2024-05-05 at 10 29 23 PM

WIP Current look selected
Screenshot 2024-05-05 at 10 30 03 PM

Breaking Changes

Driver information might not be sent out in the form currenty working on fixing that

@Atikpui007 Atikpui007 requested a review from a team as a code owner May 6, 2024 02:31
@dti-github-bot
Copy link
Member

dti-github-bot commented May 6, 2024

[diff-counting] Significant lines: 80.

@Atikpui007
Copy link
Collaborator Author

closing because the design has been changed.

Will follow new design in new PR

@Atikpui007 Atikpui007 closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants