Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned the Add/Edit Student Modal #511

Merged
merged 23 commits into from
Oct 17, 2024
Merged

Conversation

namanhboi
Copy link
Contributor

@namanhboi namanhboi commented Apr 9, 2024

Summary

Changed the styling of the Add/Edit Student Modal to reflect design by Lazim. Changed first and last name fields to just a name field and extracted the first and last name to submit to html form.

The code to extract the first and last name from one name field I took from this PR#425 by Desmond.

I still need to redesign the other multiselect needs box and the svg image for the calenders should be gray to reflect Lazim's designs.

image
What it looks like

image
Here, the correct error for an empty name shows up

image
Here you can see everything filled in and that I still need to style the multiselect accessibility dropdown

image
You can see that the first and last name was extracted correctly. Although I wasn't able to make the request to the server because of a 500.

image
Here is my error when trying to add a new student to the server

This pull request is the first step towards redesigning the Add / Edit Student Modal.

Test Plan

I tested the design on multiple screensizes and it seems to be working correctly
image

For testing the backend, I need to figure out how to connect to the server and finish the multiselect for needs to test everything.

@namanhboi namanhboi requested a review from a team as a code owner April 9, 2024 06:34
@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 9, 2024

[diff-counting] Significant lines: 266.

Copy link
Collaborator

@Atikpui007 Atikpui007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. You followed the styling to the tea and thats impressive.
A couple things though

  1. The font color for the labels I suggest you change it to match WCAG guidelines
  • a quick way to check is using this site. The ratio should be 4.5+
  1. The reason why you are getting the server error when trying to add a student is with the Address. I made a note in an older PR about that Redesigned Add Student Modal #425
  2. Leave the multiselect for the mean time I am working on that PR

@raissaji
Copy link
Contributor

Hey Nam! Like Desmond said, styling looks great! The modal adapts when I shrink the screen size, which is impressive and something I am looking to implement as well.

A few things:

  • On my machine, the modal dimensions do not follow Lazim's design. I attached an image below—I'm not sure why this is
Screenshot 2024-04-15 at 10 54 27 PM
  • Desmond said that you're getting a server error because of a conflict with address parsing. I addressed this issue in PR Student address requirements #501 by getting rid of the stringent address requirement entirely. If we merge these two PRs, I believe we should be able to add a student seamlessly

@raissaji raissaji self-assigned this Sep 23, 2024
@namanhboi
Copy link
Contributor Author

Updated color of the fonts in the Add/Edit Student Modal to reflect WCAG guidelines. Address Parsing issue still needs to be addressed in Raissa's pr. Also CI test is failiing due to timeout issue?

Atikpui007
Atikpui007 previously approved these changes Oct 17, 2024
@Atikpui007 Atikpui007 assigned namanhboi and Atikpui007 and unassigned raissaji Oct 17, 2024
@Atikpui007 Atikpui007 merged commit 81b1a6e into master Oct 17, 2024
6 checks passed
@Atikpui007 Atikpui007 deleted the nd433/redesignStudentModal branch October 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants