-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesigned the Add/Edit Student Modal #511
Conversation
[diff-counting] Significant lines: 266. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. You followed the styling to the tea and thats impressive.
A couple things though
- The font color for the labels I suggest you change it to match WCAG guidelines
- a quick way to check is using this site. The ratio should be 4.5+
- The reason why you are getting the server error when trying to add a student is with the Address. I made a note in an older PR about that Redesigned Add Student Modal #425
- Leave the multiselect for the mean time I am working on that PR
Hey Nam! Like Desmond said, styling looks great! The modal adapts when I shrink the screen size, which is impressive and something I am looking to implement as well. A few things:
|
…arriage-web into nd433/redesignStudentModal
Updated color of the fonts in the Add/Edit Student Modal to reflect WCAG guidelines. Address Parsing issue still needs to be addressed in Raissa's pr. Also CI test is failiing due to timeout issue? |
…to nd433/redesignStudentModal
…to nd433/redesignStudentModal
…into nd433/redesignStudentModal
Summary
Changed the styling of the Add/Edit Student Modal to reflect design by Lazim. Changed first and last name fields to just a name field and extracted the first and last name to submit to html form.
The code to extract the first and last name from one name field I took from this PR#425 by Desmond.
I still need to redesign the other multiselect needs box and the svg image for the calenders should be gray to reflect Lazim's designs.
What it looks like
Here, the correct error for an empty name shows up
Here you can see everything filled in and that I still need to style the multiselect accessibility dropdown
You can see that the first and last name was extracted correctly. Although I wasn't able to make the request to the server because of a 500.
Here is my error when trying to add a new student to the server
This pull request is the first step towards redesigning the Add / Edit Student Modal.
Test Plan
I tested the design on multiple screensizes and it seems to be working correctly
For testing the backend, I need to figure out how to connect to the server and finish the multiselect for needs to test everything.