Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal closes when clicking outside #484

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Modal closes when clicking outside #484

merged 3 commits into from
Sep 25, 2024

Conversation

CollinWoo
Copy link
Contributor

Summary

This pull request allows users to close a modal simply by clicking outside of the modal box.

  • modal closes once user clicks outside

Test Plan

I tested the modal by running the Carriage application locally, opening various modals, and then clicking on various positions surrounding the outside of the modal to see if the modal closes. A video demonstrating the correct behavior is shown below:

Screen.Recording.2023-11-28.at.7.59.31.PM.mov

Notes

  • For multi-step modals, clicking outside the modal for any step will close the modal. When the modal is opened again, it will revert to the first step. This may be annoying if someone accidentally clicks outside of a modal.

@CollinWoo CollinWoo requested a review from a team as a code owner November 29, 2023 01:30
@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 29, 2023

[diff-counting] Significant lines: 16.

raissaji
raissaji previously approved these changes Sep 23, 2024
@raissaji raissaji merged commit 929c82c into master Sep 25, 2024
5 checks passed
@raissaji raissaji deleted the cww72/close-modal branch September 25, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants