Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARIA Labels to different components #473

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Conversation

CollinWoo
Copy link
Contributor

@CollinWoo CollinWoo commented Oct 24, 2023

Summary

This pull request adds ARIA landmarks and labels to a variety of components on the Carriage Web App

  • Locations - Add/Edit a location Modal: Text not included in an ARIA Landmark.
  • Employees - add OR edit an employee modal: “Ensure all perceivable text is included in an ARIA landmark.”
  • Employees - card - delete: Text (“Are you sure you want to remove NAME?”) not included in an ARIA landmark.
  • Home - Select Dates Modal: ARIA attribute unsupported or prohibited.
  • Home - Add a ride: Text not included in an ARIA landmark.
  • Home - Add a Ride -> Select Driver Modal: Use non-prohibited states and properties only.
  • Add a Ride - PickUp Location: Elements ids are not unique.
  • Students - Add a Student: Needs - no label on the needs + Modal is not within ARIA Landmark

Test Plan

To be conducted

Notes

Breaking Changes

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 24, 2023

[diff-counting] Significant lines: 99.

@CollinWoo CollinWoo marked this pull request as ready for review November 14, 2023 16:36
@CollinWoo CollinWoo requested a review from a team as a code owner November 14, 2023 16:36
@CollinWoo CollinWoo changed the title Add ARIA Labels to different components [WIP] Add ARIA Labels to different components Nov 15, 2023
@Atikpui007 Atikpui007 self-assigned this Sep 18, 2024
Copy link
Collaborator

@Atikpui007 Atikpui007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aria Labels added. Intuitive task

@Atikpui007 Atikpui007 merged commit 2bc2518 into master Sep 20, 2024
6 checks passed
@Atikpui007 Atikpui007 deleted the cww72/aria-labels branch September 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants