Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BillOfMaterialsGeneratedEvent dispatch ComputeLibYearActivity #245

Merged
merged 4 commits into from
Sep 13, 2022
Merged

BillOfMaterialsGeneratedEvent dispatch ComputeLibYearActivity #245

merged 4 commits into from
Sep 13, 2022

Conversation

edwinkortman
Copy link
Contributor

@edwinkortman edwinkortman commented Sep 12, 2022 •
edited
Loading

Fixes #239

Edwin Kortman added 3 commits September 12, 2022 12:11
Add CommitId as a field to IAnalysisLocation
ed1d093 
We can type-hint on the interface but that does mean if we want to access CommitId we have to add it to the interface as well.
Let BillOfMaterialsGeneratedEvent dispatch ComputeLibYearActivity
31ca5f5 
To make it testable, the ComputeLibYearActivity was changed to have public properties.
Address linter errors
4523747
@edwinkortman edwinkortman self-assigned this Sep 12, 2022
@edwinkortman edwinkortman changed the title Bill of Materials dispatches compute libyear BillOfMaterialsGeneratedEvent dispatch ComputeLibYearActivity Sep 12, 2022
@edwinkortman edwinkortman marked this pull request as ready for review September 12, 2022 10:35
@edwinkortman edwinkortman requested a review from klhoot September 12, 2022 15:33
klhoot
klhoot approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@klhoot klhoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mscottford mscottford removed their request for review September 13, 2022 16:41
@mscottford mscottford merged commit 59b1dd9 into main Sep 13, 2022
@mscottford mscottford deleted the bom-dispatches-compute-libyear branch September 13, 2022 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klhoot klhoot klhoot approved these changes

Assignees

@edwinkortman edwinkortman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BillOfMaterialsGeneratedEvent dispatch ComputeLibYearActivity
3 participants
@edwinkortman @klhoot @mscottford