Compute history #204
Merged
Compute history #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 29, 2022 13:33
This interface will allow us to mock the service instead of having to instantiate the entire object each time we want to test it.
It's failing because the activity isn't doing anything yet.
The cache directory is needed because that's where all the relevant information about git is located.
This git path is needed later down the line for determining the history intervals. The idea is that an analysis only has one source control, it will (most likely) not mix SVN and Git for example.
The activity uses ComputeHistory.cs to determine the intervals it has to stop at, for each interval found it will fire the HistoryIntervalStopFoundEvent.cs
mscottford
requested changes
Aug 29, 2022
Corgibytes.Freshli.Cli/Migrations/20220804202314_AddCachedAnalyses.cs
Outdated
Show resolved
Hide resolved
Corgibytes.Freshli.Cli/CommandRunners/Cache/PrepareCacheActivity.cs
Outdated
Show resolved
Hide resolved
mscottford
approved these changes
Aug 29, 2022
added 5 commits
August 29, 2022 20:02
…e Cache Directory the entire time From ComputeHistory the method ComputeCommitHistory also has been removed. This is only used in the command runner, and those will get removed eventually. To save some refactoring-time remove it now.
This object is then used by the compute history command runner. The object is the combination of a repository id and the cache directory. Together they can form a path where the repository has been cloned to.
|
@mscottford I've re-requested your review as I've added the implementation for AnalysisLocation and I want to know if this is how you envisioned it. |
This should not have been removed in an earlier commit as this option is used by the analyse command (yet to be implemented).
|
Most recent commit approved during pairing session. |
mscottford
approved these changes
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149