Allow conv2d and pool2d to use dynamic dimensions for width and height. #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
reviewed
Mar 26, 2023
src/tensor_ops/conv2d/mod.rs
Outdated
| type Convolved = usize; | ||
|
|
||
| fn convolve_dim(&self) -> Self::Convolved { | ||
| (self.size() + 2 * P - K) / S + 1 |
There was a problem hiding this comment.
Suggested change
| (self.size() + 2 * P - K) / S + 1 | |
| (self.size() + 2 * P).checked_sub(K).unwrap() / S + 1 |
I think we'll need to add some sort of check/assertion for when this conv operation is valid. The const generic version does this implicitly with the where bound
|
I like how this ends up removing more code than it adds😀 |
|
Nice change 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
convolve_dimmethod to ConvAlgebra and uses it to implement ConvAlgebra for usize. Conv2d and Pool2d still require nightly, as making them work on stable would require makingConst<N>::Convolvedbeusize, which I don't think is a desirable outcome of changing toolchains.