Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conv2d #124

Merged
merged 24 commits into from
Aug 20, 2022
Merged

Add Conv2d #124

merged 24 commits into from
Aug 20, 2022

Conversation

coreylowman
Copy link
Owner

@coreylowman coreylowman commented Jul 29, 2022

Closes #1

  • Add tests for conv2d & batch_conv2d
  • Add tests for Conv2D layer
  • Add example file
  • Clean up implementation

@coreylowman coreylowman marked this pull request as draft July 29, 2022 21:51
@@ -0,0 +1,302 @@
use crate::prelude::*;

pub fn conv2d<
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a const CFG: ConvConfig could be really helpful to reduce const generic parameters here. Will require an additional feature to enable usage of structs in const

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be really helpful, especially if the amount of filters can be set independently, so there could be a default convconfig for a kernel size of 3x3 with 0 padding etc. And conv2d is nightly anyway, so another feature wouldn't hurt much

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a default option like this could use typealiasing though and would not require extra-features

src/nn/conv.rs Outdated Show resolved Hide resolved
@coreylowman coreylowman changed the title Draft: Add Conv2d Add Conv2d Aug 14, 2022
@coreylowman coreylowman marked this pull request as ready for review August 14, 2022 20:54
@coreylowman coreylowman merged commit a2024ac into main Aug 20, 2022
@coreylowman coreylowman deleted the conv-v3 branch August 20, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convolution mega issue
3 participants