-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Conv2d #124
Add Conv2d #124
Conversation
@@ -0,0 +1,302 @@ | |||
use crate::prelude::*; | |||
|
|||
pub fn conv2d< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a const CFG: ConvConfig
could be really helpful to reduce const generic parameters here. Will require an additional feature to enable usage of structs in const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be really helpful, especially if the amount of filters can be set independently, so there could be a default convconfig for a kernel size of 3x3 with 0 padding etc. And conv2d is nightly anyway, so another feature wouldn't hurt much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a default option like this could use typealiasing though and would not require extra-features
Closes #1