Convert ambiguous date into standard format. #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry to be picky, but I got bitten by some ambiguous date format problems recently so... The date I am converting (9/6/19) is Sep 6th if it is in US format and is June 9th for all other English speaking countries (I'm highlighting English countries only because this text is in English). I determined that it is US format by looking at the date of the commit. I suggest that stuff like this use [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) format because it is unambiguous, it is popular amongst developers, it is getting wider adoption, and it is a great format! Thanks.
coreybutler
approved these changes
Nov 15, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to be picky, but I got bitten by some ambiguous date format problems recently so...
The date I am converting (9/6/19) is Sep 6th if it is in US format and is June 9th for all other English speaking countries (I'm highlighting English countries only because this text is in English). I determined that it is US format by looking at the date of the commit.
I suggest that stuff like this use ISO 8601 format because it is unambiguous, it is popular amongst developers, it is getting wider adoption, and it is a great format! Thanks.