feat: Allow multiple sshkey entries with scim #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmisale
previously approved these changes
Nov 6, 2025
kulkarnisamr
previously approved these changes
Nov 6, 2025
Collaborator
|
Was this tested with multiple ssh keys? |
kevinhu-cw
reviewed
Nov 6, 2025
| for ssh_key in ssh_keys: | ||
| if ssh_key and ssh_key.strip(): | ||
| map_entry = sshkey.SshkeyMapEntry() | ||
| map_entry = UniqueSshkeyMapEntry() |
There was a problem hiding this comment.
nit: update docstring to Return UniqueSshkeyMapEntry instances from a SCIM user resource.
git-it127
force-pushed
the
multiple-sshkeys
branch
from
2e35ea0 to
781886f
Compare
bradbeam
approved these changes
Nov 7, 2025
kulkarnisamr
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.