ci: make Lint a required check (drop continue-on-error)#512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the CI Lint job a required check by dropping
continue-on-error: true.It was set non-blocking while a few react-hooks v7 findings were open. Those remaining findings are now warnings (the compiler rules
react-hooks/refs,set-state-in-effect,static-componentsare pinned towarn;exhaustive-depsstayswarn), whilereact-hooks/rules-of-hooksremains an error — so a genuine hook-correctness regression now fails the PR again.Verified the CI-relevant lint is clean:
npm run lintover the checked-out tree (main library + docs; thecoreui-icons-react/coreui-react-chartjssubmodules are not checked out in CI) reports 0 errors. No source changes needed.