Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter environment variables #310

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

nicomt
Copy link
Contributor

@nicomt nicomt commented Jun 6, 2024

Filter environment variables to prevent unintended leakage of environment variables.

@nicomt nicomt changed the title Filter environmet variables to prevent unintended leakage of environment variables. Filter environment variables Jun 6, 2024
@mrholek
Copy link
Member

mrholek commented Jun 14, 2024

@nicomt Thank you for this PR. I think that the best solution is to follow the official Vite documentation and remove process.env from vite.config.mjs - https://vitejs.dev/guide/env-and-mode

@mrholek mrholek merged commit 082ad80 into coreui:main Jun 14, 2024
@nicomt nicomt deleted the process-env-filter branch June 14, 2024 16:17
@nicomt
Copy link
Contributor Author

nicomt commented Jun 14, 2024

👌I agree. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants