CTX-6123: Added --verbose flag for all commands that could have detai… #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led execution output. Added message that leads to log file with detailed output after exception happened.
VukManojlovic
requested changes
Aug 6, 2024
added 2 commits
August 16, 2024 14:39
# Conflicts: # coretex/cli/commands/node.py # coretex/cli/modules/intercept.py # coretex/cli/modules/node.py # coretex/cli/modules/utils.py # coretex/utils/docker.py
dule1322
requested changes
Aug 26, 2024
coretex/cli/modules/utils.py
Outdated
| pass | ||
|
|
||
| # if ctx.params.get('verbose'): | ||
| # VERBOSE = True |
There was a problem hiding this comment.
Should this comment be removed?
coretex/cli/modules/utils.py
Outdated
| if param["name"] == "verbose" and param["flag_value"] == True: | ||
| CLISettings.verbose = True | ||
| except: | ||
| pass |
There was a problem hiding this comment.
Set verbose to false here
coretex/cli/modules/node.py
Outdated
|
|
||
|
|
||
| def shouldUpdate(image: str) -> bool: | ||
| def shouldUpdate(image: str, ) -> bool: |
coretex/cli/modules/intercept.py
Outdated
| logFiles = list(logPath.glob("*.log")) | ||
| latestLogFile = max(logFiles, key = lambda f: f.stat().st_mtime) | ||
|
|
||
| errorEcho(f"Exception: {str(exc)}.\nYou can see detailed logs here: {latestLogFile}") |
There was a problem hiding this comment.
An error occured. You can see the detailed logs at {filepath}
coretex/cli/commands/node.py
Outdated
| @click.option("--verbose", "verbose", is_flag = True, help = "Shows detailed output of command execution.") | ||
| @onBeforeCommandExecute(node_module.initializeNodeConfiguration) | ||
| def update(autoAccept: bool, autoDecline: bool) -> None: | ||
| def update(autoAccept: bool, autoDecline: bool, verbose: bool = False) -> None: |
There was a problem hiding this comment.
Does this need to have verbose defined explicitly?
coretex/cli/commands/node.py
Outdated
| @click.option("--verbose", "verbose", is_flag = True, help = "Shows detailed output of command execution.") | ||
| @onBeforeCommandExecute(node_module.initializeNodeConfiguration) | ||
| def start(image: Optional[str]) -> None: | ||
| def start(image: Optional[str], verbose: bool = False) -> None: |
There was a problem hiding this comment.
Does this need to have verbose defined explicitly?
…click.group and click.command decorator with slight changes that serve our needs. onBeforeCommandExecute callback is deleted all functionality is now in base_group and base_command. Minor code cleanup in scope of this task (unused imports etc.)
…true since they change the output of the command and json cant be loaded no more.
…function argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…led execution output. Added message that leads to log file with detailed output after exception happened.