Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrontendBundle] fix wishlist remove and allow purchasables #997

Merged
merged 2 commits into from
May 23, 2019
Merged

[FrontendBundle] fix wishlist remove and allow purchasables #997

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8037cbc
[FrontendBundle] fix wishlist remove and allow purchasables
dpfaffenbauer May 22, 2019
3f1edef
[StorageList] equals: Check if the product is the same type and also …
dpfaffenbauer May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[StorageList] equals: Check if the product is the same type and also … 
…the same id.
  • Loading branch information
@dpfaffenbauer
dpfaffenbauer committed May 22, 2019
commit 3f1edef8126f4c04369ab811e1983a5fe38e6342
4 changes: 3 additions & 1 deletion src/CoreShop/Component/StorageList/Model/StorageListItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ class StorageListItem implements StorageListItemInterface
*/
public function equals(StorageListItemInterface $storageListItem)
{
return $this->getProduct() === $storageListItem->getProduct();
$product = $storageListItem->getProduct();

return $this->getProduct() instanceof $product && $this->getProduct()->getId() === $product->getId();
}

/**
Expand Down