Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuBundle] introduce menu-bundle to define the menu-structure in php #854

Merged
merged 9 commits into from
Mar 19, 2019

Conversation

dpfaffenbauer
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

Introduces a new Bundle to make Menu-Building easier. The menu is now defined in PHP and loaded via a separate JS file. Calling the constructor of that JS files, will build the menu. All permissions are now checked on the server as well.

@dpfaffenbauer dpfaffenbauer added this to the 2.1.0 milestone Mar 5, 2019
@dpfaffenbauer dpfaffenbauer self-assigned this Mar 5, 2019
@dpfaffenbauer dpfaffenbauer requested a review from a team March 5, 2019 12:23
@dpfaffenbauer
Copy link
Member Author

dpfaffenbauer commented Mar 5, 2019

TODO:

  • Docs
  • Tests

@dpfaffenbauer dpfaffenbauer force-pushed the menu-bundle branch 2 times, most recently from 7086ff8 to 918f22a Compare March 16, 2019 18:22
@dpfaffenbauer dpfaffenbauer merged commit a82e82e into coreshop:master Mar 19, 2019
@dpfaffenbauer dpfaffenbauer deleted the menu-bundle branch March 22, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant