Handle unknown class names in ClassUpdate #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m0nken please rebase to 3.0 |
Allow $this->classDefinition to be assigned with null. Otherwise the code in line 33 may break (`$this->classDefinition = DataObject\ClassDefinition::getByName($className);`) and line 36 cannot be reached.
|
|
|
@dpfaffenbauer I rebased to 3.0 but now the checks fail. The failing checks do not appear to be related to the changes within my commit, though. Could you retrigger the checks? |
dpfaffenbauer
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust ClassUpdate to allow $this->classDefinition to be assigned with null. Otherwise the assignment with the result of
DataObject\ClassDefinition::getByName($className)may fail and the prepared null-check will not be reached.