Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: property must not be accessed before initialization #2036

Merged
merged 2 commits into from
Jul 6, 2022
Merged

fix: property must not be accessed before initialization #2036

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9769e63
fix: property must not be accessed before initialization
dkarlovi Jul 5, 2022
caba48a
fix: some properties are not set in ProductExtractor
dkarlovi Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: property must not be accessed before initialization
  • Loading branch information
@dkarlovi
dkarlovi authored Jul 5, 2022
commit 9769e63a0abec89a4cb46af48fa9ccf494243641
2 changes: 1 addition & 1 deletion src/CoreShop/Bundle/TrackingBundle/Resolver/ConfigResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function __construct(private SiteIdProvider $siteIdProvider, private Goog

public function getGoogleConfig(): ?ConfigObject
{
if (null !== $this->googleConfig) {
if (isset($this->googleConfig)) {
return $this->googleConfig;
}

Expand Down