fix: FP related to setting server privileges#35
Merged
Conversation
EsadCetiner
approved these changes
Oct 30, 2025
EsadCetiner
requested changes
Oct 30, 2025
Member
EsadCetiner
left a comment
EsadCetiner
left a comment
There was a problem hiding this comment.
Actually, can you add tests based on the logs the reporter submitted?
Member
Author
|
I really don't see why it is not passing. |
Member
Author
|
@EsadCetiner It is somehow possible to change plugin settings for a specific test? |
Member
I don't think so, all go-ftw does is sends a request and checks the behavior. Maybe open an issue in https://github.com/coreruleset/go-ftw/issues/new You can flip the failing test and add a comment saying it's expected to fail for now. |
Update YAML test file to enable meta section.
EsadCetiner
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32.