Fix: False positive in deck application #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving a card,the PUT method is not allowed. Content of arg "description" triggers multiple rules.
theseion
requested changes
Feb 12, 2024
Contributor
|
@EsadCetiner Would you mind taking a look as well? |
EsadCetiner
requested changes
Feb 12, 2024
Put rule in its own group. Increase readability
EsadCetiner
requested changes
Feb 13, 2024
Remove unecessary rule IDs from the triggered rules.
EsadCetiner
approved these changes
Feb 13, 2024
theseion
approved these changes
Feb 14, 2024
Contributor
|
Thank you @mivek! Thanks for the help @EsadCetiner. |
Contributor
Author
|
Glad to contribute, I am just starting to integrate crs with Nextcloud. I may open a couple more PR ^^ |
Contributor
|
Please do ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR to handle false positive when using the deck application in nextcloud
When moving a card,the PUT method is not allowed.
Content of arg "description" triggers multiple rules.